Sanitize Metric Name in Checkpoints#990
Open
vbourgin wants to merge 1 commit intometa-pytorch:masterfrom
Open
Conversation
Summary:
# Context
Metric names may be included in checkpoint names when specifying a `best_checkpoint_config`, but no verification is done on the metric name. This may lead to nested directory structures if checkpoint names contain `/`, e.g.:
f721785233
Here we use `top1_accuracy/evaluate` as the `monitored_metric`, which will create checkpoints in a nested directory:
{F1977112918}
Checkpointers won't be able to appropriately restore the checkpoint with the best monitored metric, as each checkpoint will be stored in a different directory.
# Proposed change
In this diff, we sanitize the metric name prior to checkpoint saving, replacing `/` with `_`. Now, checkpoints are saved in the same directory:
f721793003
{F1977113027}
Differential Revision: D73004419
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73004419 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Metric names may be included in checkpoint names when specifying a
best_checkpoint_config, but no verification is done on the metric name. This may lead to nested directory structures if checkpoint names contain/, e.g.:f721785233
Here we use
top1_accuracy/evaluateas themonitored_metric, which will create checkpoints in a nested directory:{F1977112918}
Checkpointers won't be able to appropriately restore the checkpoint with the best monitored metric, as each checkpoint will be stored in a different directory.
Proposed change
In this diff, we sanitize the metric name prior to checkpoint saving, replacing
/with_. Now, checkpoints are saved in the same directory:f721793003
{F1977113027}
Differential Revision: D73004419