Conversation
|
@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I opened a new PR to try v2.10.3 which is almost identical but turns the refcount debug utils off by default (until pybind111 2.11) and has some misc fixes. |
|
Hmm so it looks like there is some GIL issues. One common failure case we saw from this is trying store a python object as a global static variable (as the ctor would be called before the interpreter is initialized). |
|
Gotcha, will enable testing for #305 I'll take a look to see if there's any global static py::objects |
|
Hmm, are there atexit hooks in this codebase? I think there is an open issue with those that needs to be fixed. |
|
Hi @PaliC! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Updated to unblock pytorch/pytorch#91248 (comment) and the refcount debug utils will be useful :)