Fix otel teardown bug during unit tests #2095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The root cause is that the test creates real Counter objects that use the global OpenTelemetry meter. When Python shuts down, the order of destruction between Python objects and the Rust OpenTelemetry global state can cause a use-after-free or double-free. The fix should be to mock the inner Rust objects in the tests that don't need real telemetry, Reviewed By: amirafzali Differential Revision: D88752324
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 726f020. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The root cause is that the test creates real Counter objects
that use the global OpenTelemetry meter. When Python shuts
down, the order of destruction between Python objects and the Rust
OpenTelemetry global state can cause a use-after-free or double-free.
The fix should be to mock the inner Rust objects in the tests that don't need
real telemetry,
Reviewed By: amirafzali
Differential Revision: D88752324