Remove ncclConfig_t bindings #2086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were never used but complicate how we have to generate bindings to nccl. Differential Revision: [D88656649](https://our.internmc.facebook.com/intern/diff/D88656649/) [ghstack-poisoned]
Closed
zdevito
added a commit
that referenced
this pull request
Dec 8, 2025
These were never used but complicate how we have to generate bindings to nccl. Differential Revision: [D88656649](https://our.internmc.facebook.com/intern/diff/D88656649/) ghstack-source-id: 327844722 Pull Request resolved: #2086
meta-cla
bot
added
the
CLA Signed
These were never used but complicate how we have to generate bindings to nccl. Differential Revision: [D88656649](https://our.internmc.facebook.com/intern/diff/D88656649/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 8, 2025
Pull Request resolved: #2086 These were never used but complicate how we have to generate bindings to nccl. ghstack-source-id: 327870463 @exported-using-ghexport Differential Revision: [D88656649](https://our.internmc.facebook.com/intern/diff/D88656649/)
These were never used but complicate how we have to generate bindings to nccl. Differential Revision: [D88656649](https://our.internmc.facebook.com/intern/diff/D88656649/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 8, 2025
Pull Request resolved: #2086 These were never used but complicate how we have to generate bindings to nccl. ghstack-source-id: 327879735 @exported-using-ghexport Differential Revision: [D88656649](https://our.internmc.facebook.com/intern/diff/D88656649/)
These were never used but complicate how we have to generate bindings to nccl. Differential Revision: [D88656649](https://our.internmc.facebook.com/intern/diff/D88656649/) [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 8, 2025
Pull Request resolved: #2086 These were never used but complicate how we have to generate bindings to nccl. ghstack-source-id: 327888894 @exported-using-ghexport Differential Revision: [D88656649](https://our.internmc.facebook.com/intern/diff/D88656649/)
Closed
|
This pull request has been merged in aac8d3f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These were never used but complicate how we have to generate bindings to nccl.
Differential Revision: D88656649