[Builds] Add separate Rust build features for core, rdma and tensor_engine #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@allenwang28 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87884695. |
allenwang28
changed the title
Summary: This is the first step to supporting individual installs for Monarch capabilities, i.e. core/rdma/tensor_engine. Changes: - Modifies monarch_extension to use core, rdma, tensor_engine, full feature sets. - Switches setup.py to use MONARCH_FEATURES accepting strings rather than the 0/1 boolean only USE_TENSOR_ENGINE (also makes all the downstream changes needed to reflect it) - Renames the default wheel name from `monarch` to `torchmonarch`, to better align with what we're officially publishing to PyPI - Slight clean up to setup.py workflow Differential Revision: D87884695
allenwang28
force-pushed
the
export-D87884695
branch
from
e4c269c to
7558bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the first step to supporting individual installs for Monarch capabilities, i.e. core/rdma/tensor_engine.
Changes:
monarchtotorchmonarch, to better align with what we're officially publishing to PyPIDifferential Revision: D87884695