Add unit test for existing ac API behavior#244
Open
ailzhang wants to merge 1 commit intogh/ailzhang/3/basefrom
Open
Add unit test for existing ac API behavior#244ailzhang wants to merge 1 commit intogh/ailzhang/3/basefrom
ailzhang wants to merge 1 commit intogh/ailzhang/3/basefrom
Conversation
meta-cla
bot
added
the
CLA Signed
Author
|
The first PR is just adding a unit test (with claude :P ) to make sure I understand the current behavior 🙏 Any feedback is appreciated! |
ailzhang
changed the title
xmfan
reviewed
Nov 11, 2025
| return Transformer(model_args) | ||
|
|
||
|
|
||
| def create_joint_graph_from_model(model, input_args): |
Member
There was a problem hiding this comment.
this implementation is strange, any issues just using the same joint graph capture frontend as the rest of the repo?
autoparallel/autoparallel/api.py
Lines 301 to 310 in b1c4909
xmfan
reviewed
Nov 11, 2025
| # Define save list with operations that might be in the graph | ||
| save_list = { | ||
| torch.ops.aten.mm.default, | ||
| torch.ops.aten.addmm.default, |
Member
There was a problem hiding this comment.
i think this always gets decomposed away. and if it doesn't, it will mess up your saved node count lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):