Skip to content

Conversation

@burtenshaw
Copy link
Collaborator

@burtenshaw burtenshaw commented Dec 3, 2025

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 3, 2025
@burtenshaw burtenshaw requested a review from pankit-eng December 3, 2025 08:11
Resolved conflicts:
- envs/echo_env/models.py: took release (updated imports to openenv.core)
- envs/echo_env/server/echo_environment.py: took release (updated imports)
- src/openenv/core/env_server/http_server.py: kept pr/217 features (schema endpoints, route config, serialization)
- src/openenv/core/env_server/web_interface.py: kept pr/217 features (uses shared serialization module)
- src/openenv/core/env_server/route_config.py: moved to new location
- src/openenv/core/env_server/serialization.py: moved to new location
[ENHANCEMENT] migrate to pydantic models and add parameterized reset/step support
@AlirezaShamsoshoara
Copy link
Member

@burtenshaw Nice work! I was reading the changes in files, I think some environments still needs updates, for instance:
docs/environments/snake_env.md needs to change like other environments?

-8<-- "../../src/envs/snake_env/README.md"

To

--8<-- "../../envs/snake_env/README.md"

And rest of their files that require the updates based on this draft. I was wondering if those environments that did not get affected are meant like this or they are missed?

@burtenshaw
Copy link
Collaborator Author

@burtenshaw Nice work! I was reading the changes in files, I think some environments still needs updates, for instance:
docs/environments/snake_env.md needs to change like other environments?

-8<-- "../../src/envs/snake_env/README.md"

To

--8<-- "../../envs/snake_env/README.md"

And rest of their files that require the updates based on this draft. I was wondering if those environments that did not get affected are meant like this or they are missed?

Good catch. Yes, we will need somee docs changes and to merge and move envs that are already on main and not here. Open to a PR if you're up for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants