Open
Conversation
clehene
commented
Aug 3, 2016
clehene
commented
- Bumped version (shouldn't this be done after each release?)
- Added delete capability
|
👍 |
| # curl "http://localhost:7000/api/topic/delete?topic=t" | ||
| {"topic" : {"name" : "t", "partitions" : {"0" : "0, 1"}, "options" : {}}} | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I think DELETE is more appropriate here than a GET to /delete endpoint
Author
There was a problem hiding this comment.
@liorze I agree, however I made this consistent with the rest of the code (remove broker) which uses GET for the removal operation as well. Changing to proper HTTP DELETE operations it's, hence a change of the current API which is outside of the scope of this issue IMO.
Contributor
|
This is an awesome patch, do you think you could rebase it and I'll merge it in? I can take a crack at rebasing it too if you don't have time. |
Author
|
@steveniemitz I'll attempt a rebase hopefully tomorrow |
Merged
steveniemitz
pushed a commit
that referenced
this pull request
Jun 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.