Fix query params not being read/updated correctly in WebSocket mode (#1283)#1326
Closed
richard-to wants to merge 1 commit intomainfrom
Closed
Fix query params not being read/updated correctly in WebSocket mode (#1283)#1326richard-to wants to merge 1 commit intomainfrom
richard-to wants to merge 1 commit intomainfrom
Conversation
…1283) This fixes two bugs in query parameter handling: 1. **initialize_query_params** wasn't clearing existing params before initializing new ones. In WebSocket mode, the Context is persistent across requests (stored in self._contexts), so old query params would stick around when they should be cleared. This caused query params from the URL to not be read correctly on subsequent navigations. 2. **set_query_param** was passing `values=None` to the protobuf when deleting a query param (value=None case), instead of `values=[]`. This caused the URL to not be updated correctly when query params were deleted. These bugs only manifested in WebSocket mode because in regular SSE mode, a new Context is created for each request (stored in Flask's g object). Fixes #1283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in query parameter handling:
initialize_query_params wasn't clearing existing params before
initializing new ones. In WebSocket mode, the Context is persistent
across requests (stored in self._contexts), so old query params would
stick around when they should be cleared. This caused query params
from the URL to not be read correctly on subsequent navigations.
set_query_param was passing
values=Noneto the protobuf whendeleting a query param (value=None case), instead of
values=[].This caused the URL to not be updated correctly when query params
were deleted.
These bugs only manifested in WebSocket mode because in regular SSE mode,
a new Context is created for each request (stored in Flask's g object).
Fixes #1283