Draft
Conversation
Change-Id: I4da216d52191baabab9f63cc3ee6ae749add906f
Open
Collaborator
|
Hey - thanks for opening this PR. I left a comment on the issue: #1110 (comment) I don't think I fully understand the requested use case, but it's not clear to me how setting |
wwwillchen
reviewed
Nov 21, 2024
| title: str | ||
| stylesheets: list[str] | ||
| security_policy: SecurityPolicy | ||
| cors: CORS |
Collaborator
There was a problem hiding this comment.
Instead of a separate parameter in PageConfig, I would put CORS into SecurityPolicy (i.e. allowed_cors_origins) since CORS is security-related
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1110