TCLAP 1.2.5#2735
Open
ManuelAtWork wants to merge 5 commits into
Open
Conversation
15d2d36 to
85f7dba
Compare
bgilbert
reviewed
Apr 8, 2026
Collaborator
bgilbert
left a comment
There was a problem hiding this comment.
Some quick observations, haven't fully reviewed.
f8019df to
8e1a189
Compare
Author
|
CI used to fail for Win32 platforms. Explanation:
|
Collaborator
|
What is the nature of the "problems on Windows"? If it isn't expected to work at all there, we should disable the project entirely on Windows (with |
Author
There are 2 areas of concern:
The present wrap mirrors the policy of the original TCLAP developers: "On Win32, use at your own risk. No tests." |
8f4f37f to
6294f06
Compare
6294f06 to
0cf576d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.2.5fixes a problem withC++20(among other things)