Skip to content

TCLAP 1.2.5#2735

Open
ManuelAtWork wants to merge 5 commits into
mesonbuild:masterfrom
ManuelAtWork:tclap-1.2.5
Open

TCLAP 1.2.5#2735
ManuelAtWork wants to merge 5 commits into
mesonbuild:masterfrom
ManuelAtWork:tclap-1.2.5

Conversation

@ManuelAtWork
Copy link
Copy Markdown

v1.2.5 fixes a problem with C++20 (among other things)

@ManuelAtWork ManuelAtWork force-pushed the tclap-1.2.5 branch 11 times, most recently from 15d2d36 to 85f7dba Compare April 7, 2026 17:21
Copy link
Copy Markdown
Collaborator

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick observations, haven't fully reviewed.

Comment thread subprojects/packagefiles/tclap/meson.build Outdated
Comment thread subprojects/packagefiles/tclap/meson.build Outdated
@ManuelAtWork ManuelAtWork force-pushed the tclap-1.2.5 branch 2 times, most recently from f8019df to 8e1a189 Compare April 8, 2026 08:20
@ManuelAtWork
Copy link
Copy Markdown
Author

ManuelAtWork commented Apr 8, 2026

CI used to fail for Win32 platforms. Explanation:

  • Tests in the original TCLAP rely on bash-scripts, and were never meant to run on Windows.
  • Moreover, TCLAP is known to cause problems on Windows.
  • Wraps are not meant to fix deficits in the original code.
  • Therefore, I disabled tests on Windows.

@bgilbert
Copy link
Copy Markdown
Collaborator

bgilbert commented Apr 8, 2026

What is the nature of the "problems on Windows"? If it isn't expected to work at all there, we should disable the project entirely on Windows (with build_on in ci_config.json), not just the tests.

@ManuelAtWork
Copy link
Copy Markdown
Author

What is the nature of the "problems on Windows"? If it isn't expected to work at all there, we should disable the project entirely on Windows (with build_on in ci_config.json), not just the tests.

There are 2 areas of concern:

  • Occasional incompatilibty of the TCLAP implementation. (keywords: std:sstream, config.h, include paths, ...) It depends on the MSVC/MSYS version. Many MSVC users will be lucky, so I would not generally disable builds entirely.
  • Automated tests: They used to rely on bash (and probably line endings). So they never ran on Windows.

The present wrap mirrors the policy of the original TCLAP developers: "On Win32, use at your own risk. No tests."

ManuelAtWork and others added 5 commits April 9, 2026 14:38
This removes the extra indirection through *.sh files, which all have
the same structure. It also fixes a bug that makes tests fail when the
path contains blanks/whitespaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants