ENH: capture and report build errors when rebuilding editable wheels#859
Open
dnicolodi wants to merge 1 commit into
Open
ENH: capture and report build errors when rebuilding editable wheels#859dnicolodi wants to merge 1 commit into
dnicolodi wants to merge 1 commit into
Conversation
tobiasdiez
reviewed
Jun 29, 2026
dnicolodi
commented
Jun 29, 2026
dnicolodi
force-pushed
the
editable-verbose-on-error
branch
from
f5f1066 to
899cb5c
Compare
rgommers
reviewed
Jul 2, 2026
rgommers
left a comment
rgommers
left a comment
Contributor
There was a problem hiding this comment.
I like the idea, and the implementation is nice and concise. A few comments around robustness (encoding, ninja errors, etc.)
| for line in log: | ||
| if line.startswith('FAILED: '): | ||
| break | ||
| error = log.read() |
Contributor
There was a problem hiding this comment.
The first line that the break triggers on won't get printed here, right? Would be nice to capture that line as well.
Member
Author
There was a problem hiding this comment.
Leaving it out was a conscious decision. That line reads:
FAILED: [code={exitcode}] {target_name}
and I don't think it adds much information: the exit code is not relevant in the vast majority of the cases, and the target name is more often than not completely opaque to the user.
However, if you insist, I can include this line.
dnicolodi
force-pushed
the
editable-verbose-on-error
branch
4 times, most recently
from
fa08e0d to
b41af25
Compare
When editable-verbose is not enabled, redirect the build output to a file. When the build fails, parse this file to look for the build error and append it to the ImportError exception message. Fixes mesonbuild#820.
dnicolodi
force-pushed
the
editable-verbose-on-error
branch
from
b41af25 to
c8de736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When editable-verbose is not enabled, redirect the build output to a file. When the build fails, parse this file to look for the build error and append it to the ImportError exception message.
Fixes #820.
Replaces #750.