Bump framework-portduino to drop accept() log spam#17
Merged
Conversation
Pulls in meshtastic/framework-portduino#69, which advances the bundled libraries/WiFi submodule to meshtastic/WiFi#6 and removes the two `log(SysWifi, LogVerbose, ...)` calls in WiFiServer::available() that were firing on every poll of the accept loop. meshtasticd's main loop hits that path hundreds of times per second, so the daemon was flooding stdout with repeated "calling accept" / "accept=0" lines. The level argument was meant to suppress them at default verbosity, but cores/portduino/logging.cpp's logv() ignores level entirely. The upstream PR fixes the immediate noise problem surgically; making logv() level-aware is a separate follow-up. Old framework SHA: 447329159e67d19cefc9f47b799bc0fa0f51c010 New framework SHA: 214bf605c02c2c26d2fb963132c4bce77f416d81 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
framework-portduinogit ref inplatform.jsonto pull in meshtastic/framework-portduino#69, which itself bumpslibraries/WiFito meshtastic/WiFi#6 — removing two verboselog(SysWifi, LogVerbose, ...)calls inWiFiServer::available()that were firing on every poll of the accept loop.meshtasticdpolls that path hundreds of times per second, so the daemon was flooding stdout with:Why these were noisy despite
LogVerboseframework-portduino'scores/portduino/logging.cpp::logv()ignores itslevelargument and unconditionally writes toSerial, soLogVerboseis just as loud asLogInfo. The chain of upstream PRs fixes the immediate noise problem surgically; makinglogv()level-aware would be a wider behavioral change (every otherLogVerbosesite across the framework would suddenly go silent), so it's left as a separate follow-up.Diff
214bf60is the merge commit ofmeshtastic/framework-portduino#69onmeshtastic/framework-portduinomaster.Test plan
92b0641)214bf60)native-macosmeshtasticdagainst this branch — clean compilemeshtasticd -sis silent during idle accept polling🤖 Generated with Claude Code