Bump libraries/WiFi to pick up extern "C" / logging.h fix#68
Merged
Conversation
2 tasks
The WiFi submodule's WiFiServer.cpp had `#include "logging.h"` inside an
`extern "C" { ... }` block, which gives `arduino::log(...)` C linkage and
collides with libc's `extern "C" double log(double)` from <math.h> under
Apple Clang ("conflicting types for 'log'"). Fixed in
meshtastic/WiFi#5; this commit bumps the submodule pointer to that change.
Once this is on master, the next steps are: bump platform-native's
framework-portduino pin (meshtastic/platform-native), then drop the
bin/patch-framework-portduino-darwin.py workaround in firmware PR
meshtastic/firmware#10300 and bump platform-native's zip pin.
thebentern
force-pushed
the
bump-wifi-submodule-extern-c-fix
branch
from
14a2894 to
21e989a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
libraries/WiFifromc75a5e8to467ec17(the merge of meshtastic/WiFi#5) so this framework picks up theextern "C"/logging.hfix inWiFiServer.cpp.That nesting gave
arduino::log(...)C linkage and collided with libc'sextern "C" double log(double)from<math.h>under Apple Clang ("conflicting types for 'log'"). Linux GCC silently tolerated the misuse, which is why this never surfaced before.Context
Hit while bringing up the macOS-native portduino build — see firmware PR meshtastic/firmware#10300.
Downstream chain
bin/patch-framework-portduino-darwin.pyand itsextra_scriptsentry in[env:native-macos], then bumpportduino_base.platformto the new platform-native commit.Test plan
meshtasticdcleanly on macOS arm64 (Apple Clang) — the firmware-side pre-build patcher applies the same reordering and the resulting binary boots in SimRadio mode.🤖 Generated with Claude Code