Skip to content

Comments

fix(strings): Correct capitalization of Ham#4620

Open
alecperkins wants to merge 1 commit intomeshtastic:mainfrom
alecperkins:fix/typo
Open

fix(strings): Correct capitalization of Ham#4620
alecperkins wants to merge 1 commit intomeshtastic:mainfrom
alecperkins:fix/typo

Conversation

@alecperkins
Copy link

In reference to amateur radio operators, “ham” is not an acronym.

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the bugfix PR tag label Feb 22, 2026
@jamesarich
Copy link
Collaborator

We only need the English string, translations are sourced by Crowdin.

@alecperkins
Copy link
Author

alecperkins commented Feb 22, 2026

Updated, though I wonder if it will translate properly, or perhaps be too literal? I don’t know if "ham" is used in every language this way.

For comparison, the option on iOS: image

@jamesarich
Copy link
Collaborator

Updated, though I wonder if it will translate properly, or perhaps be too literal? I don’t know if "ham" is used in every language this way.

For comparison, the option on iOS: image

I can add a contextual note to that string for translators, I'll include a ref to this ticket.

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d8f08c3). Learn more about missing BASE report.
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4620   +/-   ##
=======================================
  Coverage        ?   16.08%           
=======================================
  Files           ?       84           
  Lines           ?     4152           
  Branches        ?      745           
=======================================
  Hits            ?      668           
  Misses          ?     3359           
  Partials        ?      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants