Open
Conversation
- Setts the -E flag to tell Python to ignore `PYTHONPATH` and `PYTHONHOME` so Meshroom's injected venv path can't contaminate the subprocess's package resolution.
Should be easier to keep updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
While trying to get this working today on Meshroom 2025.1.0, I had some issues with the package dependencies VS Meshroom's venv environment. Specifically Meshroom's version of numpy doesn't seem to play nice with what mrGeolocation needs!
I noticed that an environment var for
MESHROOM_GEOLOC_PYTHONwas set up, but this wasn't noted as part of the install process. It also means Meshroom users have to start the program from the command line for the plugin to work.Changes
I've added a venv and setup script that sets it up and installs the packages for the user. The plugin venv is used instead of Meshroom's included Python due to the
-Eflag when running. Now it works again! Hopefully this ensures that the plugin will continue to function in the future, even as Meshroom updates its dependencies! :)