Default button polarity to active-LOW across all firmware types#1612
Open
weebl2000 wants to merge 2 commits intomeshcore-dev:devfrom
Open
Default button polarity to active-LOW across all firmware types#1612weebl2000 wants to merge 2 commits intomeshcore-dev:devfrom
weebl2000 wants to merge 2 commits intomeshcore-dev:devfrom
Conversation
Contributor
|
When you say "nearly all LoRa boards..." which boards do not pull to ground when the button pressed? What would happen to those boards if this PR is merged? |
Nearly all LoRa boards use a boot button that pulls to ground when pressed.
8342496 to
34eca3a
Compare
Contributor
Author
All devices as far as I can tell, just went through the datasheets. Except T1000-E that is genuinely high. MinewSemi being high was a bug AFAIK. |
Contributor
|
Thanks for checking. T1000-E has been a problem child but with a lot of effort from the community it is finally working. Sure don't want to break its button functionality. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nearly all LoRa boards use a boot button that pulls to ground when pressed. The T1000-E is the one exception — it uses a capacitive touch button that is active-HIGH (confirmed by Meshtastic's
BUTTON_ACTIVE_LOW false).Changes:
USER_BTN_PRESSEDtoLOWwhere not already defined (ESP32Board.h, UITask.cpp, XiaoNrf52Board.h)LOWbutton checks withUSER_BTN_PRESSEDin UITask and board filesUSER_BTN_PRESSED=HIGHwithNRF_GPIO_PIN_SENSE_HIGH— changed to active-LOW withSENSE_LOWUSER_BTN_PRESSED=LOW(now the default)USER_BTN_PRESSED=HIGHandSENSE_HIGH(correct for this hardware), but fixbuttonStateChanged()to useUSER_BTN_PRESSEDinstead of hardcodedLOWI found out when I was working on #1347 — it was actually releasing the boot button that would trigger the wakeup, not the pressing.