WIP: Determine visibility based on bounding box corners vs midpoint#49
Draft
corydickson wants to merge 1 commit intomeshcenter:masterfrom
Draft
WIP: Determine visibility based on bounding box corners vs midpoint#49corydickson wants to merge 1 commit intomeshcenter:masterfrom
corydickson wants to merge 1 commit intomeshcenter:masterfrom
Conversation
|
🔨 Explore the source changes: 99511f2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #15
Just wondering if the currently used coordinate for the antenna is all we need, it's donated as the midpoint but not sure if there is other geometry used.
Where can I find the beam width as well? Assuming that they will be different depending on the type of device on each of the buildings.