test: add test for the UR5 upperarm.dae#181
Open
ManifoldFR wants to merge 2 commits intomeshcat-dev:masterfrom
Open
test: add test for the UR5 upperarm.dae#181ManifoldFR wants to merge 2 commits intomeshcat-dev:masterfrom
ManifoldFR wants to merge 2 commits intomeshcat-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for loading a complex Collada file,
upperarm.daefrom https://github.com/Gepetto/example-robot-data/blob/master/robots/ur_description/meshes/ur5/visual/upperarm.daeI'm getting this on the current HEAD
#174 yields the following (with a second angle to see better)
So it seems to fix it, but as I said in #170, this seems to mess up the pose somehow.
Applying #170 instead gives the correct pose (the one from the first screenshot but with the missing geometry)