Accommodate new lighting and color management#155
Merged
SeanCurtis-TRI merged 1 commit intomeshcat-dev:masterfrom Oct 30, 2023
Merged
Accommodate new lighting and color management#155SeanCurtis-TRI merged 1 commit intomeshcat-dev:masterfrom
SeanCurtis-TRI merged 1 commit intomeshcat-dev:masterfrom
Conversation
We've upgraded three.js from 0.149 to 0.156. This led to changes in how colors are managed and lighting calculations are performed. To account for those changes and give a *qualitatively* similar experience with the default values, we've made the following changes: - Light intensity controls now have units (candela) displayed. - The old (non physical) light intensity values have been boosted to be more or less equivalent to what they were before. - The color space of the background images has been corrected (to sRGB).
SeanCurtis-TRI
commented
Oct 27, 2023
Contributor
Author
SeanCurtis-TRI
left a comment
SeanCurtis-TRI
left a comment
There was a problem hiding this comment.
+@jwnimmer-tri for review, unless you want to pass it along.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jwnimmer-tri)
jwnimmer-tri
approved these changes
Oct 30, 2023
Contributor
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SeanCurtis-TRI)
-- commits line 4 at r1:
nit Clarity
Suggestion:
We previously upgraded
|
@jwnimmer-tri I would like to point out that this also affects the companion repositories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've upgraded three.js from 0.149 to 0.156. This led to changes in how colors are managed and lighting calculations are performed. To account for those changes and give a qualitatively similar experience with the default values, we've made the following changes:
This change is