Add UUID-based caching of geometry and materials#115
Closed
gizatt wants to merge 1 commit intomeshcat-dev:masterfrom
Closed
Add UUID-based caching of geometry and materials#115gizatt wants to merge 1 commit intomeshcat-dev:masterfrom
gizatt wants to merge 1 commit intomeshcat-dev:masterfrom
Conversation
Contributor
|
I've been starting to consider some of these same improvements myself. I'm curious if you've thought about how to keep the cache from growing without bound? If I'm reading this code correctly, it seems like if I keep calling There's also the twin side of this -- the code in |
Contributor
|
Closing this as incomplete / abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, even if a geometry or material is sent twice with the same UUID, there's no caching (at the parsing level, anyway -- maybe there's something deeper) of that declared-to-be-duplicated info. This enables UUID-based caching by creating a persistent
ExtensibleObjectLoaderthat keeps a cache of UUIDs across all parsing calls (which is more than the vanillaObjectLoaderdoes). This change can be taken advantage of by clients (e.g. meshcat-python PR #114) to save tons of bandwidth.