Implement close() functionality for meshcat viewer and zmqserver that hosts the three.js webpage#138
Open
kingjin94 wants to merge 2 commits intomeshcat-dev:masterfrom
Open
Implement close() functionality for meshcat viewer and zmqserver that hosts the three.js webpage#138kingjin94 wants to merge 2 commits intomeshcat-dev:masterfrom
kingjin94 wants to merge 2 commits intomeshcat-dev:masterfrom
Conversation
…osts the three.js webpage
Author
|
Tested with: prior to this patch vis.close() would fail and a manual killing of vis.window.server_proc would leave various processes running with ZMQbg prefix in htop's COMM / /proc//status -> Name. Implements closing suggest, e.g., here: https://stackoverflow.com/questions/26224179/zmq-socket-gracefully-termination-in-python |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Solves #87