Conversation
joewallwork
added
testing
|
The release CI fails as expected because the |
|
@copilot Fix the current errors in the |
|
@joewallwork I've opened a new pull request, #221, to work on those changes. Once the pull request is ready, I'll request review from you. |
joewallwork
moved this from In Progress
to Ready for review
in Mesh Adaptation development board
| test_suite: | ||
| uses: mesh-adaptation/docs/.github/workflows/reusable_test_suite.yml@main | ||
| with: | ||
| docker-image: 'firedrake-parmmg:release' |
There was a problem hiding this comment.
not sure where this one comes from but this doesn't contain a release firedrake (animate doesn't actually work with release atm) - I think you want firedrake-parmmg-release:latest ?
There was a problem hiding this comment.
In the docker_firedrake-parmmg_relase workflow I configured it to produce firedrake-parmmg with the release tag:
https://github.com/mesh-adaptation/docs/blob/1595b680b96c074d3f6f0b9bf3a3f4d2e64635d1/.github/workflows/docker_firedrake-parmmg_release.yml#L61
If you look at the packages https://github.com/mesh-adaptation/docs/pkgs/container/firedrake-parmmg then there are both latest and release tags from the main and release workflows, respectively. Perhaps I misconfigured something, though.
There was a problem hiding this comment.
Oh I see, sorry was looking at an old checkout of docs/ Should be as you said then indeed, but if I download that container locally, the firedrake in /opt/firedrake seems to be on the main branch
There was a problem hiding this comment.
I see the problem: when we are building the firedrake-parmmg container we always start from firedrake-parmmg-base:latest:
So it does build firedrake-parmmg-base:release succesfully, but then we don't actually use it to build firedrake-parmmg:release
stephankramer
left a comment
stephankramer
left a comment
There was a problem hiding this comment.
I just reran the tests to confirm that it's now actually failing on release :-)
which I guess should be fixed in a PR into release afterwards
But yes, good to go
github-project-automation
Bot
moved this from Ready for review
to Ready to merge
in Mesh Adaptation development board
github-project-automation
Bot
moved this from Ready to merge
to Done
in Mesh Adaptation development board
See mesh-adaptation/docs#156.
This PR adds a separate test suite workflow for the new
releasebranch. That test suite not only runs on Animate'sreleasebranch, but also with thereleaseversion of Firedrake.