Repository navigation
Fix ROOT/FK subtree propagation in shared Mechanics runtime; prove Motion→LBS consequence - #372
Merged
Merged
Conversation
… preserve research-proven source
… consumers and product limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product runtime behavior, following #365 and #368
Audited exact source: isolated existing Mechanics solver fix from #353 commit
a9f3efd225eed7d08e418c2ebfd303da3b0cb613; source blob6b08101d4beab65e9261253b10c023d31c266251identical, not a new solver. The previous direct ROOT/FK behavior moved only targeted joints, leaving descendant bones unmoved.This bounded 4-file PR brings proper declared-root/subtree propagation, child-FK precedence (regardless of control list order) and hard errors on invalid parent graphs into the mainline solver already used by Motion V2 and CanonicalMechanics. It adds independent behavioral tests that flow through actual CanonicalMesh v1 → CanonicalRig v2 → CanonicalSkin v2 → CanonicalMechanics v1 → qualified CanonicalMotion v2 sampling → solve → full LBS deformation.
Dedicated CI runs original V6 solver/Motion/Mechanics/CAS worker regressions as well as new positive/negative source-independent tests; must also pass broad mainline, platform/go and native/CAA checks before review/merge.
No trained-model, source-truth, 60fps, UI, Graphics, 6D grip, ProductRevision, .rss or unseen claims. No unrelated #353 multigoal runtime imported. This is a real mechanical runtime correctness fix, not product admission. Follow-up: source-bound interactive live runtime and Graphics/native consumer tests.