PML-302 MerLinProcessor export_config and typing#224
Conversation
|
I am not sure that I fullfill this criteria perfectly: There is one obvious typed place to look to understand what MerlinProcessor expects from offloadable layers. However, When there is no export_config method, I clearly state what the output of this method should look like. Also, a specific definition of types is generated for the errors of the output dictionary. I want your opinion on this point. |
ben9871
left a comment
There was a problem hiding this comment.
Token validation is too extreme and stops the branches tests from running. Other notes covered in a PR to this fork unrelated to the ticket(only visible now following tests with scaleway token)
There was a problem hiding this comment.
This token requirement should only apply to the remote_processor= path. For session=, authentication is owned by the ISession; Merlin creates fresh processors via session.build_remote_processor() and does not need to clone them with a token. With a real Scaleway Session, this currently makes every MerlinProcessor(session=scaleway_session) construction fail before any job is submitted.
Fix Scaleway compatibility with Perceval 1.2
|
From your markdown fixes
|
|
For 3, changed in next commit |
|
For 2, commented the probs test, right now there is no session that has probs. So the test on scaleway is not useful yet but, it is tested locally to work on artifiical backends |
|
All tests are now passing scaleway and local |
| # Output should be normalized probabilities | ||
| assert torch.all(y >= 0) | ||
| assert torch.allclose(y.sum(dim=1), torch.ones(4), atol=0.001) | ||
| # Uncomment when there is a probs backend |
There was a problem hiding this comment.
we cannot commit commented out code which the user must 'uncomment'. Find another way to do this life a conditional or a flag
Summary
Reinforced typing around the layer's export_config method necessity and its output dictionary
Related Issue
PML-302
Type of change
Proposed changes
How to test / How to run
Documentation