PML-327: Backprop guard implemented for memristor#219
Merged
ben9871 merged 32 commits intoJun 1, 2026
Merged
Conversation
ben9871
requested changes
May 21, 2026
Contributor
ben9871
left a comment
ben9871
left a comment
There was a problem hiding this comment.
A stray debug print remains, some issues with detaching tensors and observability, can enhance tests too
ben9871
approved these changes
Jun 1, 2026
Contributor
ben9871
left a comment
ben9871
left a comment
There was a problem hiding this comment.
files changed and ambiguity solved by adding a utility method for TBPTT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detaching history memristor states after num_backprop_steps forward passes to limit the memristive history depth accessed by the backwards.
Related Issue
PML-327
Type of change
Proposed changes
Adding a
num_backprop_stepsparameter to the add_memristve_phase_shifter method. This argument detaches any tensor in the memristive history that is associated with a forward pass at leastnum_backprop_steps+1iterations away.How to test / How to run
Documentation