Solved _helpers path in cloud related test#143
Closed
CassNot wants to merge 1 commit intomerlinquantum:mainfrom
Closed
Solved _helpers path in cloud related test#143CassNot wants to merge 1 commit intomerlinquantum:mainfrom
CassNot wants to merge 1 commit intomerlinquantum:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now the tests are failing when not run from merlin/ folder because the helpers.py file path is not resolved in test files
Other than that, all tests are passing !
This highlight the importance of having a workflow that tests built packages before pushing to pypi (I made a ticket for that)
Related Issue
Type of change
Proposed changes
_helpersto._helpersHow to test / How to run
run all tests for
/tmp