[WC-2817]: Fix datagrid 2 RTL issues #1997
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support in datagrid filters
…nd resize observer
…dd setuoFilesAfterEnv
samuelreichert
force-pushed
the
fix/WC-2817-dg2-rtl
branch
from
db932ad to
a71dda2
Compare
iobuhov
requested changes
Dec 3, 2025
Collaborator
iobuhov
left a comment
iobuhov
left a comment
There was a problem hiding this comment.
Why we fix ColumnResizer if story is about Filter selector? I think scope is drop-down filter.
Contributor
Author
|
We are fixing RTL for dropdown filter and filter selector, but also for the ColumnSelector. Talking with @gjulivan he agreed we should also fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Fix dropdown filter issues and column selector going out of bounds.