Skip to content

[WC-3185] DataWidgets: implement conditional rendering for datawidgets footer #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yordan-st wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WC-3185] DataWidgets: implement conditional rendering for datawidgets footer #1996

yordan-st wants to merge 1 commit into from
+39 −94

Conversation

@yordan-st
Copy link
Contributor

@yordan-st yordan-st commented Dec 2, 2025

Pull request type

Bug fix (non-breaking change which fixes an issue)

Description

  • Fixed an issue where the footer of datawidgets would take up unnecessary space when no elements were rendered inside.
  • Now the footer DOM element will only be rendered if there are child elements to display.

What should be covered while testing?

  • Test with datawidgets that have a footer
  • Enable config that would show footer components, check if they are displayed correctly
  • Disabled config that would show footer components, check if you see extra spacing and the footer DOM element.

@yordan-st yordan-st requested a review from a team as a code owner December 2, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

data-widgets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yordan-st