[WC-3146] Improve virtual scrolling in data grid 2 #1948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
reviewed
Oct 31, 2025
r0b1n
force-pushed
the
dg2-virtual-scroll-new
branch
3 times, most recently
from
735ffa8 to
02cf2af
Compare
iobuhov
reviewed
Dec 4, 2025
packages/pluggableWidgets/datagrid-web/src/model/models/grid.model.ts
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/datagrid-web/src/model/stores/GridSize.store.ts
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/datagrid-web/src/model/hooks/useInfiniteControl.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
48
to
52
| const lockGridBodyHeight = useCallback((): void => { | ||
| if (isVisible && isInfinite && hasMoreItems && gridBodyHeight === undefined && gridBody) { | ||
| gridSizeStore.setGridBodyHeight(gridBody.clientHeight - offsetBottom); | ||
| } | ||
| }, [isVisible, isInfinite, hasMoreItems, gridBodyHeight, gridBody, gridSizeStore]); |
Collaborator
There was a problem hiding this comment.
IMO, this should be an action on GridSizestore. All this deps coming from this store except isVisible. So, I think we can make action and just pass isVisible as argument.
r0b1n
force-pushed
the
dg2-virtual-scroll-new
branch
from
02cf2af to
f5e5ff4
Compare
iobuhov
requested changes
Dec 4, 2025
| import { useInfiniteControl } from "@mendix/widget-plugin-grid/components/InfiniteBody"; | ||
| import { RefObject, UIEventHandler, useCallback } from "react"; | ||
| import { usePaginationService } from "./injection-hooks"; | ||
| import { UIEventHandler } from "react"; |
Collaborator
There was a problem hiding this comment.
NIT: this might be removed but, OK :D
Comment on lines
82
to
92
| /** | ||
| * const lockGridBodyHeight = useCallback((): void => { | ||
| * if (isVisible && hasVirtualScrolling && hasMoreItems && gridBodyHeight === undefined && gridBody) { | ||
| * gridSizeStore.setGridBodyHeight(gridBody.clientHeight - offsetBottom); | ||
| * } | ||
| * }, [isVisible, hasVirtualScrolling, hasMoreItems, gridBodyHeight, gridBody, gridSizeStore]); | ||
| * | ||
| * useLayoutEffect(() => { | ||
| * setTimeout(() => lockGridBodyHeight(), 100); | ||
| * }, [lockGridBodyHeight]); | ||
| */ |
r0b1n
force-pushed
the
dg2-virtual-scroll-new
branch
from
f5e5ff4 to
2f7959d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix / New feature
Description
With recent improvements of virtual scrolling we introduced an issue with horizontal scroll where vertical scrollbar goes out of sight. To mitigate this we took a new approach and improved vertical scrolling even more. This gives the users ability scroll in both directions and have more natural look and feel when virtual scrolling is enabled.
As a small feature we introduced shadows when the grid is scrolled, so the users immediately see that the grid is in the middle of the scroll, this is a good QoL improvement.
What should be covered while testing?