Skip to content

fix: Prevent memory leak in execute_without_results #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antejavor merged 2 commits into from
Aug 14, 2025
Merged

fix: Prevent memory leak in execute_without_results #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c9db75
fix: Use `CString` to safely handle query strings in FFI call in `exe…
REASY Aug 8, 2025
4b08de3
Merge branch 'master' into fix/memleak
antejavor Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/connection/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,10 +393,13 @@ impl Connection {

/// Fully Executes provided query but doesn't return any results even if they exist.
pub fn execute_without_results(&mut self, query: &str) -> Result<(), MgError> {
// Allocate the C string without leaking. Keep it alive for the duration of the FFI call.
let c_query = CString::new(query).map_err(|_| MgError::new("Invalid query".to_string()))?;

match unsafe {
bindings::mg_session_run(
self.mg_session,
str_to_c_str(query),
c_query.as_ptr(), // no leak: pointer valid during this call
std::ptr::null(),
std::ptr::null_mut(),
std::ptr::null_mut(),
Expand Down
Loading