Add :length action for :list to schema#134
Merged
Merged
Conversation
mat-hek
approved these changes
May 27, 2026
| end | ||
| end | ||
|
|
||
| defp parse_field(data, {name, {:list, type, count: count_key}}, context) do |
Member
There was a problem hiding this comment.
NIT I'd prefer length instead of count :P
Comment on lines
+264
to
+265
| _other_msg -> | ||
| flush_buffers(acc) |
Member
There was a problem hiding this comment.
It doesn't change anything currently, but I'd rather not drop all other messages
Suggested change
| _other_msg -> | |
| flush_buffers(acc) |
varsill
requested changes
May 28, 2026
| use Mix.Project | ||
|
|
||
| @version "0.36.4" | ||
| @version "0.36.5" |
Contributor
There was a problem hiding this comment.
I've already release 0.36.5, so I think you need to rebase and bump it further to v0.36.6 ;)
kidq330
force-pushed
the
kidq330/schema_sized_list
branch
from
e4ee62a to
f5b02db
Compare
mat-hek
changed the title
:count action for :list to schema:length action for :list to schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.