Add support for nocash debug registers on the ARM7#2455
Open
AntonioND wants to merge 1 commit intomelonDS-emu:masterfrom
Open
Add support for nocash debug registers on the ARM7#2455AntonioND wants to merge 1 commit intomelonDS-emu:masterfrom
AntonioND wants to merge 1 commit intomelonDS-emu:masterfrom
Conversation
Contributor
Author
|
Fixes #2130 to some degree, but this should be improved to work with other access sizes. |
AntonioND
force-pushed
the
nocash_arm7
branch
from
d4aa67e to
5f1ef8f
Compare
Member
|
sorry for looking at this so late, but I'm not a big fan of having the wifi IO handlers fall through to the regular IO handlers... maybe we could make this more optimal with a bit of reworking. but maybe I'm just nitpicking. |
Contributor
Author
|
Hmmm without that change the accesses don't reach the right switch statement. I will take a look at it this weekend. |
Member
|
I get the technical reason behind it, that's just my "code efficiency/niceness" part talking :P I think there's a way to make this a bit better... I'm thinking about it |
Contributor
Author
|
BTW, if someone comes up with a better idea, feel free to do it. I don't mind having my name in the commit, I'd just like this to be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.