Fix deprecated defaultProps error warning#687
Fix deprecated defaultProps error warning#687tristanheilman wants to merge 3 commits intomeliorence:masterfrom
Conversation
- upgraded to work with react native 0.75.5 - tested locally with react native 0.75.5 - upgraded to typescript v5 - fixed linting error
|
Any updates on this? |
|
Why no updates on this? Any patch or suggestion to do if the update is not coming soon? |
|
BUMP |
|
+1 bump |
A patch file is provided in the test repository that I shared. It can be found at this link: I'm unsure if yarn will allow you to straight copy over the patch file into your .yarn/patches folder. You may need to follow the below steps to patch from scratch. To patch the library temporarily, you can follow the below steps:
The patch file should be created and stored in your .yarn/patches folder. You can compare it to the patch file created in the 684-test repository to confirm. |
|
Any plans to merge this soon??? This error is getting annoying. |
|
When will this fix be merged? |
|
This is now a P0 since it become an error on Expo 52 (React Native 0.76.* and Android sdk 34 target) and Google policies requires apps to be update to Android sdk 35 till August 31th. |
|
Hey, |
|
Hey, if patch from @palicko doesn't work, please try mine: |
|
@olegmilan Thanks, the patch worked perfectly |
Seems to work well for me RN 0.79+, Thanks |
|
+1 |
|
thank you for the patch, it worked. but we need this as default. any release plans? |
This worked well for me. However I was still getting some other warnings like : |
|
+1 can we please merge this |
|
I would love seeing this merged and a new version generated please. Thanks |
Checks
Description
Below is a public repository that provides a simple test on a barebones React Native 0.75.5 project. v1.0.0 shows the error that this issue describes. v2.0.0 shows the provided patch and passing tests.
https://github.com/tristanheilman/react-native-render-html-684-test/releases
NOTE: There was one item that I didn't spend time figuring out and that was the website portion of this repository. I was getting errors with the rdocusaurus-plugin-sass repository due it using a git branch checkout. I was unable to run yarn install until providing a valid repository version.
Fixes issue #684