Open
Conversation
Collaborator
|
Could you provide a test .fea file? |
Author
|
sure. these are fea test files for RTL and LTR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I’ve updated the code to support RTL kernings as well. It works on my side, but the code might be a bit messy and better be reviewed. (I’m not a pro coder, this was my first time working with Vanilla and OOP, and I had some help from ChatGPT)
I first planned to make the script decide automatically based on glyph group info as a best guess, but then I realized it’s better to let the user choose since some glyphs are neutral in direction or without Unicode values.