Add two new flags: --sync-ignore-file and --skip-item-index#55
Merged
Add two new flags: --sync-ignore-file and --skip-item-index#55
--sync-ignore-file and --skip-item-index#55Conversation
added 12 commits
January 22, 2026 21:51
oatmeaI
changed the title
--sync-ignore-file and --skip-item-index
Owner
|
Thanks, this seems like a reasonable addition. I didn't consider indexing downloaded media to be an overhead, however I didn't test large libraries over SMB and walking that is indeed going to be painfully slow. I may refactor the internally passed arguments here though as it's getting a bit nebulous with everything passed everywhere. Cheers! |
Author
|
Thank you! Agreed the arguments getting passed around is starting to get weird, I just didn't wanna touch too much stuff here :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--skip-item-indexuses the ignore.txt file as the source of truth for what's already downloaded, rather than looking through the filesystem. On my machine (~85 items in my Bandcamp collection, stored on a shared drive mounted via SMB), this option speeds up a single run from ~29.9s to ~0.9s.--sync-ignore-fileappends any downloaded items found in the filesystem to the ignore.txt file - just a slightly more convenient way to do this.This PR doesn't alter any existing functionality; new code is only touched if you pass one of the new flags.