Merged
Conversation
Owner
|
Thanks! This is a pretty extensive PR, I'll review it when I next get some time to spend on this. The features would be a nice addition. |
Owner
|
I'll merge this for now and refactor part of it. Handling of more edge cases is useful and worth having, thanks. I'm not entirely sure on some of the structure of the PR though but it's not a big project to tweak a bit later. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a few corner-cases (issue #53)
Physical-only items (i.e. those without downloads) are now correctly skipped.
Expired downloads where email confirmation from the user are now detected and skipped.
Multiple collection items sharing the same artist and title names are now treated as distinct entities by adding their item ID as suffix to the folder-name.
Handling of these missing/expired downloads is handled more explicitly. New BandcampDownloadUnavailable and DownloadExpired errors can be raised.
Sync flow has been changed to create item directories only after an item has been successfully downloaded.
pytests added around the handling of duplicate, expired and physical/digital items. Some refactoring was performed in order to support this.