MHC support#224
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slintes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ? |
|
@slintes: The following commands are available to trigger required jobs:
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test 4.13-openshift-e2e |
1 similar comment
|
/test 4.13-openshift-e2e |
| return result, err | ||
| } | ||
|
|
||
| if !r.ReconcileMHC { |
There was a problem hiding this comment.
shouldn't this be at the top of method ?
There was a problem hiding this comment.
no, the MHCChecker above isn't new
There was a problem hiding this comment.
What I mean is, in case the feature is disabled wouldn't it make sense to return immediately and skip other tests ?
There was a problem hiding this comment.
MHCChecker needs to always run 🤷🏼♂️
|
checking old NHC e2e tests /test 4.11-openshift-e2e |
|
/test 4.11-openshift-e2e |
|
/test 4.11-openshift-e2e |
|
/test 4.12-openshift-e2e |
|
/test 4.12-openshift-e2e |
|
/test 4.12-openshift-e2e |
|
After a lot of "fun" with rebase, fixing merge conflicts, and getting leases to work with MHC, unit tests are green again (locally at least). Let's see how old NHC e2e looks like now. Not ready for review! Still several TODOs in code. And no e2e for MHC yet. /test 4.13-openshift-e2e |
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
MHC needs to also remediate failed Machines which don't have a node yet. Because of that, the CR name always is the Machine name. And we can't create a node lease in this case. Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Works on OCP 4.14+ only Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Otherwise we might miss MHCChecker update in case getting MHC fails Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
|
rebased on #272 |
|
/lgtm |
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
|
/test 4.12-openshift-e2e |
|
@slintes: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test 4.13-openshift-e2e |
|
/hold cancel |
|
@slintes: Overrode contexts on behalf of slintes: e2e-k8s DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
5 participants
Handle failed machines and unhealthy nodes based on MachineHealthChecks.
This basically is a copy of the controller and unit tests from https://github.com/openshift/machine-api-operator/tree/master/pkg/controller/machinehealthcheck.
Where applicable, existing NHC code was reused.
Limitations, can potentailly be handled in a follow up:
Done:
ECOPROJECT-773