This repository was archived by the owner on Dec 14, 2023. It is now read-only.
Open
Conversation
Contributor
|
Still knowing very little about how topics work, I don't feel qualified to opine on this at great length, but it looks well-organized and well-tested. Nice work! Looking forward to hearing how the test topics from the CLI turn out. |
jtotoole
approved these changes
Dec 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the migration of the topics-mine and topics-mine-public workers from perl to python. This is almost entirely just a line by line migration, with only a few small fixes / refactors as I went. The big change is adding unit tests for all non-trivial code in mine.py. I also migrated the existing big integration test that was in test_tm_mine.t to test_mine.py.
I think test_mine.py passed at the first try once I got the test itself working, which I take as a good sign that the unit test coverage is good. I'm still nervous about plugging this directly into public topics, so I plan on turning off the worker pools and running a few production topics from the command line before turning the pools back on.