Open
Conversation
shikhar
suggested changes
Mar 5, 2022
| }, | ||
| Poll::Pending => break Poll::Pending, | ||
| Poll::Pending => { | ||
| cx.waker().wake_by_ref(); |
There was a problem hiding this comment.
Just realized, I think only the above wake is necessary. In this case the inner future being polled is responsible for waking.
Author
There was a problem hiding this comment.
valid point. i assumed the inner future was not doing its job and just added one here. this fixes the issue, but i don't have a valid reasoning about the fix itself though. also, there is a possibility that the issue could be stemming from somewhere else in the library.
the issue -- without this wake, when application-level tasks attempt to fetch the token concurrently, the tasks get hanged after fetching the token and doesn't progress further.
There was a problem hiding this comment.
Can you try to create a minimal repro?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://doc.rust-lang.org/stable/std/task/enum.Poll.html#variant.Pending