Add unconstrained tests for all optimizers

[ewu63]

Purpose

Should be good to go after #438. Turns out we never had any unconstrained tests... It's also clear that NSGA2 was never thoroughly tested.

Expected time until merged

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

Testing

Checklist

• I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
• I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
• I have run unit and regression tests which pass locally with my changes
• I have added new tests that prove my fix is effective or that my feature works
• I have added necessary documentation

[marcomangano]

The windows action failure is due to a (temporary?) failure to download the miniconda executables from the official repo.

Ensuring installer...
  Can we use bundled Miniconda?
  Can we download a custom installer by URL?
  Can we download Miniforge?
  ... will download Miniforge.
  Will fetch Mambaforge latest from https://github.com/conda-forge/miniforge/releases/latest/download/Mambaforge-Windows-x86_64.exe
  Ensuring Installer...
  Checking for cached Mambaforge@latest...
  Did not find Mambaforge-Windows-x86_64.exe latest in cache

[ewu63]

Ok that's so weird, so the NSGA2 test segfaults when running in isolated mode, but it runs fine without on my computer. Hmmm

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.17%. Comparing base (bf7d311) to head (86a0dc9).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
pyoptsparse/pyNSGA2/pyNSGA2.py	33.33%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   86.26%   86.17%   -0.09%     
==========================================
  Files          24       24              
  Lines        3399     3406       +7     
==========================================
+ Hits         2932     2935       +3     
- Misses        467      471       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kanekosh]

Now we skip the NSGA2 test, should we remove the NSGA2 options here?

[marcomangano]

That would apply to the change in pyOpt_testing.py too. I am not sure if we want to remove this completely since we might want to test it locally at some point, but we should at least adding a comment clarifying which optimizers are not tested.

[ewu63]

Added comment, in the future I'd like to bring it back once #448 is addressed

[ewu63]

@marcomangano this is ready

[marcomangano]

LGTM. Maybe when we fix the testing issues with NSGA-II we can also update the name in our code to match the metadata