Fix #43525: Improve clarity of dispatchEvent() return value#43545
Open
roshanigugale06 wants to merge 1 commit intomdn:mainfrom
Open
Fix #43525: Improve clarity of dispatchEvent() return value#43545roshanigugale06 wants to merge 1 commit intomdn:mainfrom
roshanigugale06 wants to merge 1 commit intomdn:mainfrom
Conversation
roshanigugale06
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:WebAPI
Contributor
|
Hi @roshanigugale06! Can you clarify which issue this PR is supposed to fix? #43525 seems like the wrong issue. |
Contributor
|
Preview URLs (1 page) |
Author
Hi! Thanks for pointing that out. This PR is intended to fix issue #43525 (misleading sentence in dispatchEvent() documentation). I mistakenly referenced the wrong issue number earlier. I have updated the return value description to improve clarity. Please let me know if any further changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a misleading sentence in the dispatchEvent() documentation.
Changes made:
Result:
The behavior of dispatchEvent() return value is now easier to understand.
Closes #43525
Proof of change: ISSUE (false if event is cancelable, and at least one of the event handlers which received event called Event.preventDefault(). Otherwise true.)
(Screenshot attach here)