[Editorial review] BiDi - Add pages for browser module commands#43518
[Editorial review] BiDi - Add pages for browser module commands#43518
Conversation
juliandescottes
left a comment
There was a problem hiding this comment.
Just one question/suggestion regarding user contexts, but this looks very accurate, thanks!
|
|
||
| ## User contexts | ||
|
|
||
| A user context is a collection of zero or more top-level contexts (tabs) within the browser. Tabs within the same user context share the same browser storage (such as cookies and session data), while tabs in different user contexts are completely isolated from one another and do not share any browser data. A user context with no tabs is called an empty user context. |
There was a problem hiding this comment.
Would it make sense to give examples of practical implementations of user contexts in browsers (containers in Firefox, private browsing mode in Chrome), or is it too implementation/vendor specific?
There was a problem hiding this comment.
That's a good idea - it's what helped me understand what a user context is, though I think a guide might be a better place to include the examples. I've made a note.
|
This pull request has merge conflicts that must be resolved before it can be merged. |
files/en-us/web/webdriver/reference/bidi/modules/browser/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/webdriver/reference/bidi/modules/browser/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/webdriver/reference/bidi/modules/browser/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/webdriver/reference/bidi/modules/browser/createusercontext/index.md
Show resolved
Hide resolved
files/en-us/web/webdriver/reference/bidi/modules/browser/createusercontext/index.md
Show resolved
Hide resolved
files/en-us/web/webdriver/reference/bidi/modules/browser/getclientwindows/index.md
Show resolved
Hide resolved
files/en-us/web/webdriver/reference/bidi/modules/browser/removeusercontext/index.md
Outdated
Show resolved
Hide resolved
|
|
||
| - [`invalid argument`](/en-US/docs/Web/WebDriver/Reference/Errors/InvalidArgument) | ||
| - : The `userContext` field is `"default"`. The default user context cannot be removed. | ||
| - `no such user context` |
There was a problem hiding this comment.
The specific error entry should probably be added now and as well linkified.
There was a problem hiding this comment.
For now, I'm trying to prioritize modules, commands, and events that are being tracked in various spreadsheets.
But I want to definitely get to error and capability pages as well!
Added this one to my To-Do list so it's not lost. 🙂
|
Thanks for the review @whimboo and @juliandescottes! Please take another look when you get a chance. |
whimboo
left a comment
There was a problem hiding this comment.
Thanks for the updates! It looks good to me as well.
|
Thanks @whimboo! |
|
Hi @pepelsbey, would appreciate an editorial review from you. Thanks! |
Description
This PR adds the following pages:
browser.closebrowser.createUserContextbrowser.getClientWindowsbrowser.getUserContextsbrowser.removeUserContextNote:
Since support is mixed right now, I'll add pages for
browser.setClientWindowStateandbrowser.setDownloadBehaviorin a future PR.Additional details
The browser landing page includes two new sections:
These can likely by moved to a guide in the future.
Spec links
Related issue
Doc issue: mdn/mdn#339