Add manifest fields required for PWA app migration#29356
Merged
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Contributor
|
@Dp-Goog did you forget to push a change here? I'm still seeing the tags. |
github-actions
bot
added
size:xs
Contributor
Author
|
They should be fine now, apologies for the extra work here. Not quite sure what happened. Can you PTAL again? |
ddbeck
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the 2 fields required for manifest migrations to work for BCD, so that they can be tracked via WebDX features.
Test results and supporting details
https://github.com/Dp-Goog/browser-compat-data/actions/runs/23661314087/job/68932027229
There seems to be some failures because it cannot find the
app-migrationfeature ID in https://github.com/web-platform-dx/web-features, but otherwise looks more or less good?Related issues
N/A