Add partial implementation notes for align-self, justify-self, and place-self properties on absolute positioned elements#29342
Conversation
…ace-self properties
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
ddbeck
left a comment
There was a problem hiding this comment.
This is a weird case when it comes to partial_implementation. Our guidelines don't require us to set it. But there are multiple vendor bugs, so maybe it's still partial anyway.
I'm left wondering: if everyone agrees this is buggy behavior, why did everyone implement it the same way? 🤔
| "impl_url": "https://crbug.com/376097648", | ||
| "partial_implementation": true, | ||
| "notes": "Only works when the element has a non-auto inset." |
There was a problem hiding this comment.
I think these need to be in the "bug" style rather than the implementation style, something like shown below.
But the more serious issue here is something like, "what does "work" mean?
It might be easier to explain if we invert the formulation, but I don't know what to fill in for the … here:
| "impl_url": "https://crbug.com/376097648", | |
| "partial_implementation": true, | |
| "notes": "Only works when the element has a non-auto inset." | |
| "partial_implementation": true, | |
| "notes": "If `inset: auto` applies to the element, then … . See [bug 376097648](https://crbug.com/376097648)" |
|
@fantasai is this something you can help us on? |
Summary
This PR adds partial implementation flags and notes for
align-self,justify-self, andplace-selffor all browsers, when they apply to absolutely positioned elements.I tested this in Safari, Firefox, and Chrome, and discussed with Mozilla engineers @dshin-moz and @emilio.
My understanding is that there's a missing piece in all browsers where you can't just apply the above properties and expect them to work on their own. They also require a non-auto
insetvalue.Test results and supporting details
Test case: https://bug2026174.bmoattachments.org/attachment.cgi?id=9557965
The red box should be centered in the gray box.
Code:
Adding
inset:0;on the child element makes it work.I'm not entirely sure I'm reading the spec correctly though, and the placement of auto-inset abspos elements may actually be correct. But, WPT seems to show browser differences in this area at least: https://wpt.fyi/results/css/css-align/abspos/align-self-static-position-001.html?label=experimental&label=master&aligned
Related issues