Update Firefox data for api.SVGElement.load_event#26686
Conversation
This PR updates and corrects version values for Firefox and Firefox Android for the `load_event` member of the `SVGElement` API. The `alternative_name` property was incorrectly used in this context.
queengooborg
added
the
data:api
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
| "partial_implementation": true, | ||
| "notes": "Firefox uses a non-standard `SVGLoad` event. See [bug 620002](https://bugzil.la/620002) for implementation status of the standard `load` event." |
There was a problem hiding this comment.
I'm not sure about setting partial here. What is the impact of using the non-standard SVGLoad event?
The spec mentions:
In previous SVG specifications the load event was called SVGLoad and could be dispatched immediately after parsing an element but before the related resource(s) were fully loaded.
I could therefore imagine that Chrome and Safari also used this deprecated (?!) SVGLoad event.
There was a problem hiding this comment.
Looking at the spec, I'm not seeing anything that stands out as notable about the SVGLoad event from a web developer perspective. Perhaps a note isn't even needed!
There was a problem hiding this comment.
Based on that paragraph and the load event description:
The load event is dispatched only to structurally external elements and to the Window, when the corresponding external resources have finished loading.
We could have a subfeature "Dispatches after external resources are loaded".
@queengooborg What do you think?
There was a problem hiding this comment.
PS: I think the alternative_name is correct, as you need to do svg.addEventListener("SVGLoad", listener), see: https://github.com/search?q=%2FaddEventListener%5C%28%5B%22%27%5DSVGLoad%5B%22%27%5D%2F&type=code
3 participants
This PR updates and corrects version values for Firefox and Firefox Android for the
load_eventmember of theSVGElementAPI. Thealternative_nameproperty was incorrectly used in this context.