'Created a Keras Based Iterator, correct a previous bug from master'#105
Open
tchaton wants to merge 3 commits intomdbloice:masterfrom
Open
'Created a Keras Based Iterator, correct a previous bug from master'#105tchaton wants to merge 3 commits intomdbloice:masterfrom
tchaton wants to merge 3 commits intomdbloice:masterfrom
Conversation
Owner
|
Hi @tchaton, thanks a lot, I will take a close look at that as soon as I get the chance, most likely on Monday. |
Author
|
I have forgot to import threading inside Augmentor/Pipeline.py |
Owner
|
I am not sure if relying on ImgAug makes that much sense... well, do you mean that Augmentor should provide an API so that it could interact with ImgAug easily, or do you mean that it would use ImgAug as a dependency? |
Author
|
Hello, I have seen some errors in my code due to the notebook I was dev in.
I will change that. I am meaning that it would be nice to wrap the
https://github.com/aleju/imgaug transformations into Augmentor. This
library is awesome for providing imediate pipeline, we should focus on
improving that and not re-code already existing augmentation.
2018-04-13 16:53 GMT+00:00 Marcus D. Bloice <notifications@github.com>:
… I am not sure if relying on ImgAug makes that much sense... well, do you
mean that Augmentor should provide an API so that it could interact with
ImgAug easily, or do you mean that it would use ImgAug as a dependency?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#105 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMRCHRUtfmgvu6--1KacnYtD51GpLvUgks5toNgdgaJpZM4TTg1E>
.
|
Author
|
I have corrected it. It should work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have observed that keras_generator was randomly sampling in range(0, len (self.augmentor_images) -1) which doesn't actually a full iteration over the data. I modified the code to add Keras Iterator support.
I also added a with_indexes with can be useful, if you want to track the images coming out of the generator.