Throw helpful exception on null blockingInfo, in ImageReader.cpp #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When errors occur in nitf_ImageIO_getBlockingInfo, it returns a NULL pointer and sets error to a helpful message. Previously the code wasn't checking for this, leading to a later less helpful error like "Invalid handle". This enables the more precise errors to be passed up the call stack to the caller.
Author
|
I immediately got the message "You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information." Sorry if I should be following some other process, holler if I need to change or resubmit this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When errors occur in nitf_ImageIO_getBlockingInfo, it returns a NULL pointer and sets error to a helpful message. Previously the code wasn't checking for this, leading to a later less helpful error like "Invalid handle". This two-line fix enables the more precise errors to be passed up the call stack to the caller.