Fix version detection to support all semver formats and remove unused variable#5
Merged
Merged
Conversation
Co-authored-by: mdaashir <85205726+mdaashir@users.noreply.github.com>
Co-authored-by: mdaashir <85205726+mdaashir@users.noreply.github.com>
Co-authored-by: mdaashir <85205726+mdaashir@users.noreply.github.com>
Co-authored-by: mdaashir <85205726+mdaashir@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add analytics and industry-specific agents for version 2.3
Fix version detection to support all semver formats and remove unused variable
Jan 15, 2026
mdaashir
approved these changes
Jan 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves version detection in the dependencyAnalyzer tool to support all valid semver formats instead of only caret-prefixed versions. It also removes an unused variable.
Changes:
- Introduced a
getMajorVersion()helper function using regex to extract major versions from any semver format (^, ~, >=, >, <, exact versions, wildcards) - Refactored webpack and React version detection to use the new helper instead of
.startsWith('^')checks - Removed unused
contentvariable in go.mod detection block
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@copilot apply changes based on the comments in this thread |
…verage Co-authored-by: mdaashir <85205726+mdaashir@users.noreply.github.com>
Co-authored-by: mdaashir <85205726+mdaashir@users.noreply.github.com>
Contributor
Author
Applied all changes from the review thread:
All 31 functional tests now passing. |
…e I/O Co-authored-by: mdaashir <85205726+mdaashir@users.noreply.github.com>
mdaashir
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dependencyAnalyzertool used fragile.startsWith('^')checks that only detected caret-prefixed versions, missing~4.0.0,>=4.0.0,4.46.0, and other valid semver formats.Changes
getMajorVersion()helper that extracts major version from any semver format (^,~,>=,>,<, exact, wildcards)contentvariable in go.mod detection blockgetMajorVersion()function to verify extraction from all semver formats and edge casesTesting
The changes are minimal and focused, improving the robustness of version detection while ensuring comprehensive test coverage.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.