Fix macOS build by using standard STRIP_LIBS variable#1
Open
StanWijn wants to merge 1 commit intomclements:developfrom
Open
Fix macOS build by using standard STRIP_LIBS variable#1StanWijn wants to merge 1 commit intomclements:developfrom
StanWijn wants to merge 1 commit intomclements:developfrom
Conversation
Owner
|
Thank you for bringing this issue to my attention. Your code did not strip the file on Linux. Given that stripping is not portable across implementations (and it only reduces the file size by 50%), I propose removing the stripping from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded
strip --strip-debugcommand fails on non-GNU systems like macOS, which use a different syntax. The version of strip included with Apple's Command Line Tools doesn't recognize the --strip-debug option.This commit replaces the custom command with the R-provided
$(STRIP_LIBS)variable, allowing the build system to use the platform-specific command.